Posted: 2014-08-08 18:59:29
Version: CE 1.9.0.0
Status: Open
Reported By: Colin O'Dell
Steps to reproduce: The "catch (Mage_Core_Exception)" block should "return" immediately, like the catch block below it. However, it doesn't. This causes two issues: - The admin is redirected back to the customer grid instead of the edit form they were just on. - The customer data remains stashed in the session. Editing a different customer causes the stashed data to overwrite the other customer. To reproduce this issue: 1. Throw a Mage_Core_Exception anywhere within the "try" block of Mage_Adminhtml_CustomerController::saveAction(). 2. Edit any customer (we'll call them Customer A). 3. Save the form. 4. Edit a different customer (we'll call them Customer B). 5. Notice how the form is showing Customer A's data. As mentioned above, the solution is to simply "return;" at the end of that catch block. Expected Result: Admin should be redirected back to the edit page. Actual Result: Admin is redirected to the customer list instead. The customer data stashed in the session is then popped into whatever customer you edit next, EVEN IF ITS A DIFFERENT CUSTOMER.
Version: CE 1.9.0.0
Status: Open
Reported By: Colin O'Dell
Steps to reproduce: The "catch (Mage_Core_Exception)" block should "return" immediately, like the catch block below it. However, it doesn't. This causes two issues: - The admin is redirected back to the customer grid instead of the edit form they were just on. - The customer data remains stashed in the session. Editing a different customer causes the stashed data to overwrite the other customer. To reproduce this issue: 1. Throw a Mage_Core_Exception anywhere within the "try" block of Mage_Adminhtml_CustomerController::saveAction(). 2. Edit any customer (we'll call them Customer A). 3. Save the form. 4. Edit a different customer (we'll call them Customer B). 5. Notice how the form is showing Customer A's data. As mentioned above, the solution is to simply "return;" at the end of that catch block. Expected Result: Admin should be redirected back to the edit page. Actual Result: Admin is redirected to the customer list instead. The customer data stashed in the session is then popped into whatever customer you edit next, EVEN IF ITS A DIFFERENT CUSTOMER.